-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files): improve delete display name when trashbin is disabled #49199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
susnux
approved these changes
Nov 11, 2024
Contributor
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense for me, but lets wait on @skjnldsv as there was a lot of trouble on this action in the past.
d11fc8a to
dea6469
Compare
Member
Author
|
cc @skjnldsv Friendly ping as you are the expert on this code :) |
skjnldsv
approved these changes
Nov 19, 2024
Member
|
Looks good, make sense. |
Signed-off-by: Richard Steinmetz <[email protected]>
dea6469 to
d9eb29c
Compare
This was referenced Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
files_trashbin.Delete permanentlyinstead ofLeave this share. This confuses some users.Both display names
Leave this shareandDisconnect storageshould not be influenced by the presence of the trashbin (isTrashbinEnabled()).Before
After
Checklist