fix: don't set 'name' on null metadata #49291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
Altahrim,
provokateurin and
yemkareems
and removed request for
a team
Member
|
Why is this bad? |
Member
Author
Any code using this will assume that a non-null result contains the expected set of metadata, not just a name |
Member
|
I see. I also forgot that setting a key on null actually turns it into an array... PHP is fun |
provokateurin
requested changes
Nov 14, 2024
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
encoding-wrapper-metadata
branch
from
d64fe1e to
ae30269
Compare
provokateurin
approved these changes
Dec 3, 2024
come-nc
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the metadata ends up being an array with just the name set.