fix(core): Do not use v-html for translation output
#49346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
artonge,
nickvergessen,
skjnldsv and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
artonge
approved these changes
Nov 18, 2024
skjnldsv
approved these changes
Nov 19, 2024
Member
|
/compile rebase |
skjnldsv
added
4. to release
The content that can be renderered does *not* include HTML (see `recommended` object). But `v-html` was used, this is potentially dangerous, even though we sanitize the translation values, so no urgent harm but better safe than sorry. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/drop-v-html
branch
from
302bc11 to
2887c16
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
/backport 52769a4 to stable29 |
Member
|
/backport 52769a4 to stable28 |
2 tasks
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/49346/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 52769a4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49346/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/49346/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 52769a4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49346/stable28Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The content that can be rendered does not include HTML (see
recommendedobject).But
v-htmlwas used, this is potentially dangerous, even though we sanitize the translation values, so no urgent harm but better safe than sorry.Checklist