improve handling of large single-part s3 uploads #49352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
artonge,
juliusknorr,
provokateurin and
yemkareems
and removed request for
a team
provokateurin
approved these changes
Nov 18, 2024
juliusknorr
approved these changes
Nov 18, 2024
icewind1991
force-pushed
the
s3-disable-multipart
branch
4 times, most recently
from
945eef2 to
c4b57af
Compare
icewind1991
force-pushed
the
s3-disable-multipart
branch
2 times, most recently
from
df82691 to
ef0ce7c
Compare
artonge
approved these changes
Dec 3, 2024
Member
Author
|
Failing checks are relevant, still working on this |
icewind1991
added
2. developing
this should reduce potential memory issues if the limit is set very high Signed-off-by: Robin Appelman <[email protected]>
…ream size is known Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
s3-disable-multipart
branch
from
ef0ce7c to
6cf66f9
Compare
Member
Author
|
re-requesting reviews since there were some significant changes |
juliusknorr
reviewed
Dec 5, 2024
| $stats = fstat($stream); | ||
| if (is_array($stats) && isset($stats['size'])) { | ||
| $size = $stats['size']; | ||
| $this->logger->warning("stream size $size"); |
Member
There was a problem hiding this comment.
debugging leftover? otherwise warning seems a bit high as log level
juliusknorr
approved these changes
Dec 5, 2024
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
small comment, otherwise still 👍
provokateurin
approved these changes
Dec 6, 2024
Member
|
Can we backport this to stable30? |
Member
Author
|
/backport to stable30 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the risk of the memory size ballooning in cases where
putSizeLimithas been made very high (because the setup doesn't have a working multi-part upload for example)