Skip to content

chore: stricter access to testremote endpoint #49541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Altahrim merged 1 commit into from
Nov 28, 2024
Merged

chore: stricter access to testremote endpoint #49541

Altahrim merged 1 commit into from
Nov 28, 2024

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Nov 28, 2024 •
edited
Loading

Summary

Add rate limit and stricter checks for testremote endpoint

Checklist

@Altahrim Altahrim self-assigned this Nov 28, 2024
@Altahrim Altahrim added this to the Nextcloud 31 milestone Nov 28, 2024
@Altahrim Altahrim added 2. developing Work in progress php Pull requests that update Php code enhancement labels Nov 28, 2024
@Altahrim
Copy link
Collaborator Author

Altahrim commented Nov 28, 2024

/backport to stable30

@Altahrim
Copy link
Collaborator Author

Altahrim commented Nov 28, 2024

/backport to stable29

@Altahrim
Copy link
Collaborator Author

Altahrim commented Nov 28, 2024

/backport to stable28

@Altahrim Altahrim force-pushed the chore/add-rate-limit-remotetest branch from a839cf4 to ae1c3b3 Compare November 28, 2024 10:22
@Altahrim Altahrim marked this pull request as ready for review November 28, 2024 10:26
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 28, 2024
@Altahrim Altahrim enabled auto-merge November 28, 2024 10:26
artonge
artonge approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining what the regexp is matching?

provokateurin
provokateurin approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @artonge

@Altahrim Altahrim merged commit 871dc78 into master Nov 28, 2024
190 checks passed
@Altahrim Altahrim deleted the chore/add-rate-limit-remotetest branch November 28, 2024 10:45
This was referenced Nov 28, 2024
Merged
Merged
Merged
@Altahrim
Copy link
Collaborator Author

Altahrim commented Nov 28, 2024

Seems auto-merge did its job… It matches URI reserved characters (I removed the : to be able to specify a port)

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@provokateurin provokateurin provokateurin approved these changes

Assignees

@Altahrim Altahrim

Labels

3. to review Waiting for reviews enhancement php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

4 participants

@Altahrim @artonge @provokateurin