fix(updater): Stop expiring secret prematurely

[joshtrichards]

• Resolves: Web update cannot continue after long backup updater#574
• Resolves: Log updater.secret creation and expiration #45714

Summary

#43967 introduced a regression in the handling of the expiration of updater.secret. The result is that updater.secret is expired at the next job interval (~10 minutes). If the web Updater takes >10 minutes this prevents it from continuing.

• Fixed expiration handling
• Added logging when we expire the secret
• Added cleanup of the updater.secret.created value when we expire a secret
• Added handling for config_is_read_only in the AdminController
• Changed ResetToken background job unit tests to catch the scenario addressed by this PR
• Expanded ResetToken background job unit test coverage in general
• Expanded AdminController unit test coverage in general

TODO

• Tests: Confirm new tests are working (I eliminated the static used in the ResetToken test since it didn't seem to serve a purpose but I may have broken it so may require another look)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[joshtrichards]

/backport to stable30

[artonge]

• Rebased
• Fixed php-cs error
• Fixed unit test error

Resolved

[artonge]

/backport to stable32

[SystemKeeper]

Looks like this will now log a warning on each run, as the default value from getValueInt was removed and no check for non-zero values was added. https://help.nextcloud.com/t/warning-updatenotification-cleared-old-updater-secret-that-was-created-1763885703-seconds-ago-every-hour/236299

[gvanteylingen]

Experiencing same log issue Cleared old updater.secret that was created xxxxxx seconds ago, twice every 65 minutes after updating to 32.0.2.