fix(files): cancel renaming on enter if no file name changes #49693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
artonge,
nfebe and
szaimen
and removed request for
a team
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
Cypress will pass once the compiled assets are commited |
artonge
approved these changes
Dec 9, 2024
nfebe
approved these changes
Dec 10, 2024
Member
Author
|
/compile rebase / |
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/files-rename-esc
branch
from
351fd02 to
1ccce41
Compare
2 tasks
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/49693/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 23265177 1ccce41f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49693/stable30Error: Failed to push branch backport/49693/stable30: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
/backport to stable30 |
2 tasks
Member
|
I think this broke CI: https://github.com/nextcloud/server/actions/runs/12255492578/job/34190215905?pr=49747 |
4 tasks
Member
Author
|
Weird, this passed 🤔 |
Member
Author
|
Rebase your PR, seems like it works 🤔 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no changes have been made, pressing enter should also cancel the rename.