fix(unified-search): load more than 5 items in folder filter #50129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
changed the title
nfebe
force-pushed
the
fix/load-more-than-5-items-in-folder-filter
branch
5 times, most recently
from
6834285 to
fc45650
Compare
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
susnux
reviewed
Jan 28, 2025
susnux
reviewed
Jan 28, 2025
nfebe
force-pushed
the
fix/load-more-than-5-items-in-folder-filter
branch
from
fc45650 to
0b8b621
Compare
JuliaKirschenheuter
approved these changes
Jan 29, 2025
Contributor
JuliaKirschenheuter
left a comment
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
tested and seems to be resolved ;)
Each provider may search from a particular app so we should use that for searching. Before this commit, we used `provider.id` instead of `provider.appId` the problem with the previous approach is that it forces the provider id to be a valid search provider (an app that supports search) limiting the developers ability to use unique IDs to identify the different providers (especially plugin providers) inside the places filter. For example the Files search plugin "In folder" (search in folder plugin) was required to have id as `files` while the files provider itself already has id as `files`. Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]>
…er search Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/load-more-than-5-items-in-folder-filter
branch
from
0b8b621 to
a5307ac
Compare
susnux
approved these changes
Jan 29, 2025
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
This was referenced Jan 29, 2025
Contributor
|
Broke search for other apps |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load more than 5 items for in-folder search...