feat(settings): advanced deploy options #50230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey18106
force-pushed
the
feat/settings/advanced-deploy-options
branch
2 times, most recently
from
cc2b48a to
fc483fa
Compare
andrey18106
force-pushed
the
feat/settings/advanced-deploy-options
branch
from
995ffb4 to
d055a63
Compare
susnux
requested changes
Jan 20, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Please use NcDialog for consistent design, then you also have to do much less custom styling ;)
Also the dialog content currently is not good for accessibility, I left some notes on it.
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
andrey18106
force-pushed
the
feat/settings/advanced-deploy-options
branch
3 times, most recently
from
7180276 to
d23fb8d
Compare
oleksandr-nc
approved these changes
Jan 20, 2025
Contributor
oleksandr-nc
left a comment
oleksandr-nc
left a comment
There was a problem hiding this comment.
Tested in terms of functionality - it works.
susnux
approved these changes
Jan 20, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Accessibility wise better ✅
Did not test with external apps though.
andrey18106
added
4. to release
Signed-off-by: Andrey Borysenko <[email protected]>
andrey18106
force-pushed
the
feat/settings/advanced-deploy-options
branch
from
a549e10 to
73c138b
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds modal window to configure Deploy options for ExApps
Checklist