test(group): fix frequent testSearchGroups failure

[joshtrichards]

Summary

Fixes one of the causes of us frequently needing to rerun unit tests. Specifically it fixes this test:

There was 1 failure:

1) Test\Group\DatabaseTest::testSearchGroups
Failed asserting that 3 is identical to 2.

/home/runner/actions-runner/_work/server/server/tests/lib/Group/Backend.php:133

Cause:

The testSearchGroups() test shares its group namespace with other tests. These tests often call getGroupName() without a parameter. This causes this function to generate a random 13 character group name.

These randomized group names frequently (enough) contain the string sequence bar somewhere embedded in them. And getGroups() searches all configured groups using ILIKE.

As a result, the getGroups() call can return results from other tests that just happen to match on bar.

This then leads to search here to return unexpected groups. Obviously then the assert here fails. A "good enough" solution here is to adjust the test to use a longer unique string. In my testing this small adjustment was sufficient. It can still fail in theory but should be fairly unlikely now.

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• [na] Screenshots before/after for front-end changes
• [na] Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[joshtrichards]

/backport to stable30

[joshtrichards]

/backport to stable29

[susnux]

Thats a funny thing 😅