Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 27, 2025

Summary

Scanner checks both /<user> /<user>/files directories:

  1. If it exists on cache and on disk
  2. If it is writable
  3. If by chance path is overwritten with ext mountpoint

1 can still fail, if overwritten path of 3 is cached, and default dir doesn't exist, so 3 should be check first

UPD: another issue appeared while testing, added $relativePath to NotFoundException

Checklist

@Antreesy Antreesy added this to the Nextcloud 32 milestone Jan 27, 2025
@Antreesy Antreesy self-assigned this Jan 27, 2025
@Antreesy
Copy link
Contributor Author

Questions:

  • was there a reason to not check it first in initial PR?
  • will the periodic file scans (triggered by cron) work with that consideration?

@Antreesy Antreesy marked this pull request as draft January 28, 2025 14:37
@Antreesy Antreesy marked this pull request as ready for review February 10, 2025 08:49
@Antreesy Antreesy force-pushed the fix/49887/early-check-for-overwritten-home branch from a9fa476 to 4fc44d5 Compare February 10, 2025 09:02
@Antreesy Antreesy force-pushed the fix/49887/early-check-for-overwritten-home branch from 4fc44d5 to 42cd771 Compare February 17, 2025 08:24
@Antreesy Antreesy force-pushed the fix/49887/early-check-for-overwritten-home branch from 42cd771 to 7d0650c Compare June 18, 2025 15:24
@Antreesy Antreesy requested a review from a team as a code owner June 18, 2025 15:24
@Antreesy Antreesy requested review from Altahrim, ArtificialOwl and sorbaugh and removed request for a team, Altahrim, ArtificialOwl and sorbaugh June 18, 2025 15:24
@skjnldsv skjnldsv force-pushed the fix/49887/early-check-for-overwritten-home branch from 7d0650c to 809d638 Compare August 1, 2025 07:31
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 1, 2025
@skjnldsv skjnldsv merged commit 0200882 into master Aug 1, 2025
207 of 213 checks passed
@skjnldsv skjnldsv deleted the fix/49887/early-check-for-overwritten-home branch August 1, 2025 08:29
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants