-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(contactsmenu): adjust padding to new design #50532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable31 |
|
/backport to stable30 |
958fb8e to
d40031d
Compare
|
Why does this even need custom styling? Could it just use the default ncaction styles? |
I wish. The problem is that contact menu actions may inject custom image URLs as their icons which cannot be used with our That is why we need custom styles here. |
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats not all that changed, the NcAvatar above still uses the 44px. I think the current design is the default, so removing size should work (but not tested).
|
/backport to stable32 |
Thank you, that did the trick. |
Signed-off-by: Richard Steinmetz <[email protected]>
d40031d to
4e89f86
Compare
Summary
Padding and white space inside the contacts menu has not yet been adjusted to the new clickable area of 34 px.
Checklist