Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jan 29, 2025

  • Resolves: #

Summary

Padding and white space inside the contacts menu has not yet been adjusted to the new clickable area of 34 px.

Before After
image image

Checklist

@st3iny st3iny added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: contacts menu labels Jan 29, 2025
@st3iny st3iny added this to the Nextcloud 32 milestone Jan 29, 2025
@st3iny st3iny self-assigned this Jan 29, 2025
@st3iny
Copy link
Member Author

st3iny commented Jan 29, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented Jan 29, 2025

/backport to stable30

@st3iny st3iny force-pushed the fix/contactsmenu/padding branch from 958fb8e to d40031d Compare January 29, 2025 12:40
@ChristophWurst
Copy link
Member

Why does this even need custom styling? Could it just use the default ncaction styles?

@st3iny
Copy link
Member Author

st3iny commented Jan 29, 2025

Why does this even need custom styling? Could it just use the default ncaction styles?

I wish. The problem is that contact menu actions may inject custom image URLs as their icons which cannot be used with our NcAction* components. The components only accept inline SVGs, material design icons or legacy icon classes.

That is why we need custom styles here.

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats not all that changed, the NcAvatar above still uses the 44px. I think the current design is the default, so removing size should work (but not tested).

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 11, 2025
@st3iny st3iny marked this pull request as draft July 21, 2025 12:18
@AndyScherzinger
Copy link
Member

/backport to stable32

@st3iny
Copy link
Member Author

st3iny commented Sep 12, 2025

Thats not all that changed, the NcAvatar above still uses the 44px. I think the current design is the default, so removing size should work (but not tested).

Thank you, that did the trick.

@st3iny st3iny force-pushed the fix/contactsmenu/padding branch from d40031d to 4e89f86 Compare September 12, 2025 11:45
@st3iny st3iny requested a review from susnux September 12, 2025 11:45
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 12, 2025
@st3iny st3iny marked this pull request as ready for review September 12, 2025 11:45
@st3iny st3iny requested a review from a team as a code owner September 12, 2025 11:45
@st3iny st3iny requested review from nfebe and sorbaugh and removed request for a team September 12, 2025 11:45
@AndyScherzinger AndyScherzinger merged commit d0117e9 into master Sep 12, 2025
141 of 145 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/contactsmenu/padding branch September 12, 2025 20:31
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 12, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: contacts menu

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

6 participants