fix(unified-search): filteredProviders now inherits all provider props #50592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
nfebe
force-pushed
the
fix/noid/in-folder-search
branch
from
7c8d9ca to
9b65d37
Compare
artonge
approved these changes
Feb 3, 2025
The main providers come from both the backend and client side plugins such as `in-folder` search. The main providers may carry callbacks functions and other information that should be passed to the `filteredProviders`. This is important because the current code does not make a distinction between `filteredProviders` and `providers` rightly so, becuase they are the same thing! Without the mentioned distinction above, sooner or later, we try to access a property on the `filteredProviders` which we did not transfer with the manual property copy. ---- This fix prevents in-folder search from searching everywhere when "load more results" is clicked; Essentially ignoring the in-folder search filter. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/noid/in-folder-search
branch
from
9b65d37 to
d2fc45a
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
This was referenced Feb 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main providers come from both the backend and client side plugins such as
in-foldersearch. The main providers may carry callbacks functions and other information that should be passed to thefilteredProviders. This is important because the current code does not make a distinction betweenfilteredProvidersandprovidersrightly so, becuase they are the same thing!Without the mentioned distinction above, sooner or later, we try to access a property on the
filteredProviderswhich we did not transfer with the manual property copy.This fix prevents in-folder search from searching everywhere when "load more results" is clicked; Essentially ignoring the in-folder search filter.