fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize #50640
Conversation
… serialize Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
fix/taskprocessing-cache
branch
from
3949475 to
49a5212
Compare
Co-authored-by: Julien Veyssier <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
… serialize Signed-off-by: Marcel Klehr <[email protected]>
|
/backport to stable31 |
|
/backport to stable30 |
|
|
||
| $this->availableTaskTypes = $availableTaskTypes; | ||
| $this->cache->set('available_task_types', $this->availableTaskTypes, 60); | ||
| $this->distributedCache->set('available_task_types_v2', serialize($this->availableTaskTypes), 60); |
There was a problem hiding this comment.
Hey @marcelklehr, I'm curious why a distributed cache is preferred here? Doesn't this increase the latency of the request? Is there a need to synchronize the cached value across all application servers?
There was a problem hiding this comment.
Hey
Is there a need to synchronize the cached value across all application servers?
I think so, yes, they should all have the same value to avoid failing tasks sent from the state of one server and received on a different server. The chance of that happening is slim, though, as the cached value shouldn't change very often.
There was a problem hiding this comment.
Would it be possible to adjust the code to handle the case more gracefully? A local cache has a very low latency and scales horizontally. The distributed cache has high latency and creates a bottleneck when scaling out.
There was a problem hiding this comment.
Sure, what do you have in mind?
There was a problem hiding this comment.
they should all have the same value to avoid failing tasks sent from the state of one server and received on a different server.
handling this case better, and using the local cache again.
Checklist