Skip to content

Conversation

@julien-nc
Copy link
Member

Issue

In the transfer ownership personal settings, searching the "new owner" with an email address didn't work. The search request is returning some users but they are not displayed in the NcSelect.

Fix

  • Make the NcSelect non filterable
  • Remove the label prop
  • Add a subname attribute to the options (with user.shareWithDisplayNameUnique as value)

Additional changes

  • Adjust style to have the label on top of the NcSelect
  • Give the NcSelect the same width as the "choose file" button. A larger NcSelect help to see the full title and subline of its option items.

Before

image

After

image

This could be backported to 29, 30 and 31.

@julien-nc julien-nc added this to the Nextcloud 32 milestone Feb 14, 2025
@julien-nc julien-nc requested review from a team and susnux and removed request for a team February 14, 2025 16:31
@julien-nc julien-nc requested a review from skjnldsv as a code owner February 14, 2025 16:31
@julien-nc julien-nc requested review from Pytal and skjnldsv February 14, 2025 16:31
@julien-nc
Copy link
Member Author

/compile

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for disabling local filtering this looks good to me

…ithDisplayNameUnique in item subline, adjust style

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the fix/noid/transfer-ownership-select branch from 62d60af to d8c24b1 Compare February 17, 2025 10:31
@julien-nc
Copy link
Member Author

/compile

@julien-nc julien-nc enabled auto-merge February 17, 2025 10:32
Signed-off-by: nextcloud-command <[email protected]>
@julien-nc julien-nc merged commit cddcc17 into master Feb 17, 2025
120 checks passed
@julien-nc julien-nc deleted the fix/noid/transfer-ownership-select branch February 17, 2025 10:53
@julien-nc
Copy link
Member Author

/backport to stable30

@julien-nc
Copy link
Member Author

/backport to stable29

@julien-nc
Copy link
Member Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants