fix: Fix psalm taint false-positives by small refactorings #50864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly make it clear that we trust admin input or that we correctly escape strings. Signed-off-by: Côme Chilliet <[email protected]>
susnux
approved these changes
Feb 18, 2025
nickvergessen
approved these changes
Feb 18, 2025
Contributor
Author
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of #50800
Mostly make it clear that we trust admin input or that we correctly
escape strings.
There is one last taint error, but I do not know how to avoid it. Psalm confuses array keys and values at some point and thinks there is a tainted value in array key while it’s in value.
Checklist