fix(LDAP): use ldap_set_option over putenv to disable cert check #51096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
a team,
artonge,
come-nc and
provokateurin
and removed request for
a team
provokateurin
approved these changes
Feb 27, 2025
come-nc
reviewed
Mar 3, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
You forgot to remove the putenv?
Member
Author
🤦 |
the putenv option was not working reliable anymore anyway Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/ldap-setopt-for-disabling-certcheck
branch
from
3d0cd6d to
939a8d5
Compare
come-nc
approved these changes
Mar 3, 2025
artonge
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the putenv option was not working reliable anymore anyway
Checklist