fix(files_sharing): ensure downloaded file has the correct filename #51152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable31 |
provokateurin
approved these changes
Mar 3, 2025
AndyScherzinger
approved these changes
Mar 4, 2025
susnux
force-pushed
the
fix/files-sharing-download
branch
from
6cfc50b to
6b1c456
Compare
skjnldsv
approved these changes
Mar 4, 2025
Member
|
|
susnux
commented
Mar 4, 2025
susnux
force-pushed
the
fix/files-sharing-download
branch
2 times, most recently
from
37dc0d3 to
963d926
Compare
Single file shares use the share token as source name, so we need to use the displayname. To do so we need to set the download attribute to the displayname of the file to download. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-sharing-download
branch
from
963d926 to
a215286
Compare
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Single file shares use the share token as source name, so we need to use the displayname. To do so we need to set the download attribute to the displayname of the file to download.
Checklist