Allow to delete files without trashbin + add unit tests + some refactoring #51394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
skjnldsv
reviewed
Mar 11, 2025
susnux
force-pushed
the
fix/files-trashbin-files-integration
branch
from
a8480dd to
6e463df
Compare
1. Refactor to make code better testable (move columns and view source to `files_views` folder) 2. Fix deletion time fallback (JS Date vs unix timestamp for "delted"-column) 3. Correctly sort `deletedBy` and `originalLocation` columns to use natural sort like any other column 4. Add unit tests for columns and views Signed-off-by: Ferdinand Thiessen <[email protected]>
1. correctly return null instead of void in empty trash action 2. use constant instead of magic value for action ID 3. add unit tests for empty trash action 4. add unit tests for trashbin api Signed-off-by: Ferdinand Thiessen <[email protected]>
1. do not rely on magic string but use constant ID for trashbin view 2. add unit tests for restore action Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-trashbin-files-integration
branch
from
6e463df to
07535e7
Compare
Contributor
Author
Seems to be a regression of #50077 cc @provokateurin |
Contributor
Author
confirmed - we need this in 31 |
Contributor
Author
|
/backport to stable31 |
2 tasks
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Regarding files integration of files_trashbin
deletedByandoriginalLocationcolumns to use natural sort like any other columnChecklist