Skip to content

feat(files): add command to automatically rename filenames #51608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 3 commits into from
May 5, 2025
Merged

feat(files): add command to automatically rename filenames #51608

susnux merged 3 commits into from
May 5, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 20, 2025 •
edited
Loading

Summary

Make it easier for admins to rename all files when e.g. enabling Windows compatibility (ref #44963 ).

Checklist

susnux
susnux commented Apr 4, 2025
View reviewed changes
@susnux susnux force-pushed the feat/sanitize-filenames-command branch 2 times, most recently from 4343ae9 to 0f0846f Compare April 4, 2025 17:18
@susnux susnux marked this pull request as ready for review April 4, 2025 17:19
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 4, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Apr 4, 2025
@susnux susnux added the pending documentation This pull request needs an associated documentation update label Apr 4, 2025
skjnldsv
skjnldsv reviewed Apr 5, 2025
View reviewed changes
come-nc
come-nc reviewed Apr 7, 2025
View reviewed changes
@susnux susnux self-assigned this Apr 16, 2025
@susnux susnux requested a review from come-nc April 16, 2025 13:21
@susnux susnux force-pushed the feat/sanitize-filenames-command branch from 0f0846f to 5f0e99a Compare April 16, 2025 13:21
come-nc
come-nc approved these changes Apr 17, 2025
View reviewed changes
@Rello
Copy link
Contributor

Rello commented Apr 23, 2025

Hello @susnux
thank you for this PR. Frank is requesting this for our instance also.

What do you think about a simulation-parameter?
it would be interesting to output the files to be renamed in a test-run first to give the admin an idea bout the scope

@susnux susnux force-pushed the feat/sanitize-filenames-command branch from d2481e2 to 1ec65e7 Compare April 23, 2025 17:51
@susnux
Copy link
Contributor Author

susnux commented Apr 23, 2025

What do you think about a simulation-parameter?

This is implemented using --dry-run.

@ChristophWurst ChristophWurst mentioned this pull request Apr 24, 2025
Open
8 tasks
@susnux susnux force-pushed the feat/sanitize-filenames-command branch from 1ec65e7 to 437349c Compare April 24, 2025 08:52
@marcelklehr
Copy link
Member

marcelklehr commented Apr 24, 2025 •
edited
Loading

Can we please expose the sanitizeName method in OCP? By adding it directly to IFilenameValidator perhaps? This would be very useful for integration apps like integration_google, integration_dropbox etc

@sorbaugh sorbaugh mentioned this pull request Apr 25, 2025
Closed
4 tasks
@susnux susnux mentioned this pull request Apr 30, 2025
Merged
@susnux susnux removed the pending documentation This pull request needs an associated documentation update label Apr 30, 2025
@susnux
Copy link
Contributor Author

susnux commented Apr 30, 2025

Can we please expose the sanitizeName method in OCP? By adding it directly to IFilenameValidator perhaps? This would be very useful for integration apps like integration_google, integration_dropbox etc

Yes, but I would like to do that in a follow up to not overload the PR :)
(would directly create a PR after merge).

susnux and others added 3 commits April 30, 2025 16:32
@susnux susnux force-pushed the feat/sanitize-filenames-command branch from 437349c to 3657c2a Compare April 30, 2025 14:32
@susnux susnux requested a review from skjnldsv April 30, 2025 14:42
@Rello
Copy link
Contributor

Rello commented May 5, 2025

Hello,

can you please also backport this to 31?
We are requested to have it on your instance

@susnux susnux merged commit c668703 into master May 5, 2025
232 of 245 checks passed
@susnux susnux deleted the feat/sanitize-filenames-command branch May 5, 2025 13:47
@susnux

This comment was marked as resolved.

Sign in to view
1 similar comment
@skjnldsv
Copy link
Member

skjnldsv commented May 5, 2025

/backport to stable31

@backportbot backportbot bot mentioned this pull request May 5, 2025
Merged
2 tasks
@susnux
Copy link
Contributor Author

susnux commented May 6, 2025

@Rello

can you please also backport this to 31?

Done and backport adjusted

@susnux susnux mentioned this pull request May 8, 2025
Merged
4 tasks
@sorbaugh sorbaugh moved this from 🏗️ In progress to ☑️ Done in 📁 Files team May 8, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorbaugh sorbaugh sorbaugh approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner

@artonge artonge Awaiting requested review from artonge artonge is a code owner

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@susnux susnux

Labels

3. to review Waiting for reviews enhancement feature: files 🍂 2025-Autumn

Projects

📁 Files team
Status: ☑️ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatically renaming old filenames when enforcing windows filenames

7 participants

@susnux @Rello @marcelklehr @skjnldsv @sorbaugh @come-nc