-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(systemtags): Dispatch events when bulk assigning system tags #51649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(systemtags): Dispatch events when bulk assigning system tags #51649
Conversation
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but didn't test.
Signed-off-by: Roland Scheidel <[email protected]>
2ba1dd6 to
a842d91
Compare
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, code looks good
|
/backport to stable31 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
The setObjectIdsForTag method is missing event dispatching. This prevents apps from reacting
to tag changes when using the bulk tag assignment feature which was added with Nextcloud 31.
This creates a different beheaviour to when tags are assigend via the sidebar, where the assignTags and unassignTags methods are used which do dispatch the events.
This fix:
Checklist