fix(login): Improve CSRF error message for better user understanding #51697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the CSRF error message displayed in the login form to provide more specific information to the user. Instead of the generic less helpful error. Signed-off-by: nfebe <[email protected]>
nfebe
requested review from
Altahrim,
artonge,
marcoambrosini,
skjnldsv and
susnux
Altahrim
approved these changes
Mar 25, 2025
Contributor
Author
|
/compile |
AndyScherzinger
approved these changes
Mar 25, 2025
Signed-off-by: nextcloud-command <[email protected]>
skjnldsv
approved these changes
Mar 25, 2025
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
2 tasks
This was referenced Mar 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at thee client/backend the only reason why a user would see this message is if the csrf fails so the message should be much more specific.