Skip to content

fix(settings): Handle email change restriction separately from display name change restriction #51745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Apr 3, 2025
Merged

fix(settings): Handle email change restriction separately from display name change restriction #51745

skjnldsv merged 3 commits into from
Apr 3, 2025

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Mar 27, 2025 •
edited by susnux
Loading

Summary

Not stored in the backends, so no need to touch those as well.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Mar 27, 2025
@provokateurin provokateurin added this to the Nextcloud 32 milestone Mar 27, 2025
@provokateurin provokateurin requested review from a team as code owners March 27, 2025 08:32
@provokateurin provokateurin requested review from artonge, icewind1991, sorbaugh and susnux and removed request for a team March 27, 2025 08:32
@provokateurin
Copy link
Member Author

provokateurin commented Mar 27, 2025

/backport to stable31

@provokateurin
Copy link
Member Author

provokateurin commented Mar 27, 2025

/backport to stable30

@provokateurin
Copy link
Member Author

provokateurin commented Mar 27, 2025

/backport to stable29

@provokateurin provokateurin force-pushed the fix/settings/email-change-restriction branch 3 times, most recently from 2e0bd9e to 9d48db7 Compare March 28, 2025 11:13
@provokateurin
Copy link
Member Author

provokateurin commented Mar 28, 2025

/compile

@AndyScherzinger AndyScherzinger requested a review from blizzz March 30, 2025 06:49
artonge
artonge reviewed Mar 31, 2025
View reviewed changes
susnux
susnux reviewed Apr 2, 2025
View reviewed changes
@susnux susnux force-pushed the fix/settings/email-change-restriction branch from 0929491 to 53794d9 Compare April 2, 2025 16:38
@susnux susnux requested a review from artonge April 2, 2025 16:39
@susnux susnux force-pushed the fix/settings/email-change-restriction branch 2 times, most recently from f0eccf5 to 5152b27 Compare April 2, 2025 16:49
provokateurin and others added 2 commits April 2, 2025 19:06
@provokateurin @susnux @artonge
fix(settings): Handle email change restriction separately from displa…
eb98e99 
…y name change restriction

Co-authored-by: provokateurin <[email protected]>
Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Louis <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
refactor: add migration for email setting
e7859f0 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/settings/email-change-restriction branch from 5152b27 to e7859f0 Compare April 2, 2025 17:06
@susnux
Copy link
Contributor

susnux commented Apr 2, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
7157787 
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv merged commit fff9648 into master Apr 3, 2025
197 of 210 checks passed
@skjnldsv skjnldsv deleted the fix/settings/email-change-restriction branch April 3, 2025 06:19
This was referenced Apr 3, 2025
Merged
Merged
Merged
@nickvergessen nickvergessen mentioned this pull request Apr 3, 2025
Merged
This was referenced Apr 10, 2025
Closed
Closed
@provokateurin provokateurin added the pending documentation This pull request needs an associated documentation update label May 6, 2025
@provokateurin provokateurin mentioned this pull request May 6, 2025
Merged
@provokateurin provokateurin removed the pending documentation This pull request needs an associated documentation update label May 6, 2025
@provokateurin provokateurin mentioned this pull request May 25, 2025
Merged
3 tasks
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz

@artonge artonge Awaiting requested review from artonge

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: Primary email cannot be changed/set 'allow_user_to_change_display_name' only affecting 'display name' not 'email address'

7 participants

@provokateurin @susnux @AndyScherzinger @artonge @skjnldsv @nextcloud-command