Skip to content

fix: Use login name to check the password #51870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 1 commit into from
Apr 2, 2025
Merged

fix: Use login name to check the password #51870

susnux merged 1 commit into from
Apr 2, 2025

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Apr 2, 2025

@artonge artonge requested a review from a team as a code owner April 2, 2025 13:50
@artonge artonge requested review from ArtificialOwl, skjnldsv and sorbaugh and removed request for a team April 2, 2025 13:50
@artonge artonge added bug 3. to review Waiting for reviews feature: authentication php Pull requests that update Php code labels Apr 2, 2025
@artonge artonge added this to the Nextcloud 32 milestone Apr 2, 2025
@artonge artonge mentioned this pull request Apr 2, 2025
Closed
8 tasks
@artonge artonge requested review from come-nc and yemkareems April 2, 2025 14:54
@artonge
Copy link
Contributor Author

artonge commented Apr 2, 2025

/backport to stable31

@artonge
Copy link
Contributor Author

artonge commented Apr 2, 2025

/backport to stable30

@artonge
Copy link
Contributor Author

artonge commented Apr 2, 2025

/backport to stable29

@artonge
Copy link
Contributor Author

artonge commented Apr 2, 2025

/backport to stable28

@susnux susnux merged commit e659f2c into master Apr 2, 2025
195 of 204 checks passed
@susnux susnux deleted the artonge/fix/use_loginname_to_check_password branch April 2, 2025 17:20
@backportbot
Copy link

backportbot bot commented Apr 2, 2025

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/51870/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3bff9ee3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51870/stable28

Error: Failed to check for changes with origin/stable28: No changes found in backport branch

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

This was referenced Apr 2, 2025
Merged
Merged
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Apr 2, 2025

I think 28 doesn't have this 🤔

@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request bug feature: authentication php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't authenticate when Nextcloud want to confirm password

4 participants

@artonge @skjnldsv @susnux