Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 18, 2025

Summary

counted words should always be translated using n. We can still simply concat the segments with punctuation, this always works regardless of the language used (even with RTL / LTR languages).

Checklist

@susnux susnux added bug 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters labels Apr 18, 2025
@susnux susnux added this to the Nextcloud 32 milestone Apr 18, 2025
@susnux susnux requested review from a team and skjnldsv as code owners April 18, 2025 22:38
@susnux susnux requested review from nfebe and szaimen and removed request for a team April 18, 2025 22:38
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, much simpler. 🙈

counted words should always be translated using `n`.
We can still simply concat the segments with punctation, this always
works regardless of the language used (even with RTL / LTR languages).

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/files-summary branch from 6732bc1 to 04f7d4a Compare April 30, 2025 15:54
@susnux
Copy link
Contributor Author

susnux commented Apr 30, 2025

/compile

Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit df69eb5 into master Apr 30, 2025
139 of 145 checks passed
@susnux susnux deleted the fix/files-summary branch April 30, 2025 17:11
@susnux
Copy link
Contributor Author

susnux commented May 20, 2025

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: language/translations (l10n/i18n) Localization and translation matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[l10n] Singular and plural

5 participants