Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 23, 2025

Summary

If a new file is created then:

  1. a version is created
  2. the author is set in the meta data

those two are done in separate event listeners with the same priority.
In some situations they are sorted in such a way that 2 is executed before 1 and causing an issue due to version not found for update.
As 2 always needs to be done after 1 we need to reduce the priority of the second event listener.

Checklist

@susnux susnux requested a review from a team as a code owner April 23, 2025 11:12
@susnux susnux requested review from icewind1991, nfebe and sorbaugh and removed request for a team April 23, 2025 11:12
@susnux susnux added this to the Nextcloud 32 milestone Apr 23, 2025
@susnux
Copy link
Contributor Author

susnux commented Apr 23, 2025

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Apr 23, 2025

/backport to stable31

@susnux susnux requested review from artonge and removed request for sorbaugh April 23, 2025 11:13
@susnux
Copy link
Contributor Author

susnux commented Apr 23, 2025

/backport to stable29

@susnux susnux merged commit 9df998e into master Apr 29, 2025
191 checks passed
@susnux susnux deleted the fix/files-versions-author branch April 29, 2025 09:02
@backportbot
Copy link

backportbot bot commented Apr 29, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/52369/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2020760f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52369/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Apr 29, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/52369/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2020760f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52369/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Apr 29, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/52369/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2020760f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52369/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants