Skip to content

Conversation

@spalmurray
Copy link
Contributor

As suggested by @skjnldsv, this PR pins all the codecov actions to commit hashes rather than just versions. Also upgrades some of the invocations to the latest versions. There should be no breaking changes, but we'll see what the CI run does.

Additionally, this adds a check for TESTING=true in the bundle analysis config. I noticed the bundle reports looked very strange in the Codecov app. Some poking around revealed this seems to be due to a weird interaction with cypress tests. For these tests, the environment variable TESTING is set to true, so by disabling bundle uploads when that's the case, we can hopefully avoid this weirdness.

The test analytics dashboard is looking great! It seems to have found a flake and some slow tests: https://app.codecov.io/github/nextcloud/server/tests/master

Let me know if you have any questions!

@spalmurray
Copy link
Contributor Author

Also @skjnldsv I'm planning to make a PR in https://github.com/nextcloud/.github in the next week or two 🙂

@spalmurray spalmurray marked this pull request as ready for review May 1, 2025 15:55
@spalmurray spalmurray requested review from a team as code owners May 1, 2025 15:55
@spalmurray spalmurray requested review from artonge, nfebe and skjnldsv and removed request for a team May 1, 2025 15:55
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!

@AndyScherzinger AndyScherzinger merged commit 5644f33 into nextcloud:master May 5, 2025
190 of 204 checks passed
@AndyScherzinger AndyScherzinger added this to the Nextcloud 32 milestone May 5, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants