Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented May 2, 2025

@szaimen szaimen added bug 3. to review Waiting for reviews labels May 2, 2025
@szaimen szaimen added this to the Nextcloud 32 milestone May 2, 2025
@szaimen szaimen requested a review from a team as a code owner May 2, 2025 08:11
@szaimen szaimen requested review from come-nc, nfebe and skjnldsv and removed request for a team May 2, 2025 08:11
@szaimen szaimen requested review from hamza221 and st3iny May 2, 2025 20:40
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admins should make this check required?

@szaimen
Copy link
Contributor Author

szaimen commented May 2, 2025

Admins should make this check required?

The problem is that the test runs in the documentation repo but the config parameters get synced from the server repo over to the documenation repo. So not sure how to solve this best. I would for now refrain from adding the same test here in server as this is the only place in the config sample where an occ command is mentioned afaics...

@szaimen szaimen force-pushed the enh/noid/fix-docs-ci branch from ee14e7b to 1e3d56e Compare May 4, 2025 11:07
@szaimen szaimen requested a review from rakekniven May 4, 2025 11:07
@szaimen szaimen force-pushed the enh/noid/fix-docs-ci branch from 1e3d56e to 8683a9b Compare May 4, 2025 11:10
@szaimen szaimen requested a review from rakekniven May 4, 2025 11:13
@szaimen szaimen enabled auto-merge May 4, 2025 11:30
@szaimen szaimen merged commit f068350 into master May 4, 2025
197 of 205 checks passed
@szaimen szaimen deleted the enh/noid/fix-docs-ci branch May 4, 2025 11:38
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants