fix: throw a better error if we can't get the encrypted header size #52707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
provokateurin,
skjnldsv and
yemkareems
and removed request for
a team
provokateurin
approved these changes
May 9, 2025
icewind1991
force-pushed
the
encryption-no-header-size-error
branch
2 times, most recently
from
1936925 to
87eb0ca
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
encryption-no-header-size-error
branch
from
87eb0ca to
b0b8159
Compare
skjnldsv
approved these changes
May 10, 2025
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
This was referenced May 12, 2025
Member
|
/backport to stable29 |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of erroring later down the line because of the header size of 0 with a cryptic "ValueError: fread(): Argument #2 ($length) must be greater than 0". Throw an error with a more meaningful message.