Skip to content

fix: hide guests group from principal backend #52914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 1 commit into from
May 23, 2025
Merged

fix: hide guests group from principal backend #52914

kesselb merged 1 commit into from
May 23, 2025

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented May 16, 2025 •
edited
Loading

Summary

Make the GroupPrincipalBackend respect hideFromCollaboration

TODO

  • ...

Checklist

@kesselb kesselb added this to the Nextcloud 32 milestone May 16, 2025
@kesselb kesselb self-assigned this May 16, 2025
@kesselb kesselb added bug 2. developing Work in progress labels May 16, 2025
st3iny
st3iny approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense from a CalDAV perspective. I'd respect the behavior of the default sharee autocomplete.

@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 23, 2025
@kesselb kesselb force-pushed the bug/noid/hide-guests-groups branch from 50a84c0 to 5876653 Compare May 23, 2025 13:24
@kesselb kesselb marked this pull request as ready for review May 23, 2025 13:24
@kesselb kesselb requested a review from a team as a code owner May 23, 2025 13:24
@kesselb kesselb requested review from ArtificialOwl, SebastianKrupinski, artonge and come-nc and removed request for a team May 23, 2025 13:24
@kesselb kesselb merged commit 8cf03bd into master May 23, 2025
204 of 208 checks passed
@kesselb kesselb deleted the bug/noid/hide-guests-groups branch May 23, 2025 16:19
@kesselb
Copy link
Contributor Author

kesselb commented May 23, 2025

/backport to stable31

@kesselb
Copy link
Contributor Author

kesselb commented May 23, 2025

/backport to stable30

This was referenced May 23, 2025
Merged
Merged
@kesselb kesselb mentioned this pull request May 28, 2025
Open
kesselb added a commit that referenced this pull request Jun 6, 2025
@kesselb
fix: hide guests group when searching for principals
f79b189 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb mentioned this pull request Jun 6, 2025
Merged
4 tasks
kesselb added a commit that referenced this pull request Jun 10, 2025
@kesselb
fix: hide guests group when searching for principals
a85734d 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 10, 2025
@kesselb
fix: hide guests group when searching for principals
4a8221b 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 13, 2025
@kesselb
fix: hide guests group when searching for principals
49d2987 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 15, 2025
@kesselb
fix: hide guests group when searching for principals
b85c9a7 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 16, 2025
@kesselb
fix: hide guests group when searching for principals
e672236 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 16, 2025
@kesselb
fix: hide guests group when searching for principals
261d219 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 17, 2025
@kesselb
fix: hide guests group when searching for principals
8b66f35 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
backportbot bot pushed a commit that referenced this pull request Jun 17, 2025
@kesselb @backportbot
fix: hide guests group when searching for principals
2d293ee 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 17, 2025
@kesselb
fix: hide guests group when searching for principals
528489a 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 17, 2025
@kesselb
fix: hide guests group when searching for principals
89f20f0 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb mentioned this pull request Jun 17, 2025
Merged
backportbot bot pushed a commit that referenced this pull request Jun 17, 2025
@kesselb @backportbot
fix: hide guests group when searching for principals
f1cd8e4 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 17, 2025
@kesselb
fix: hide guests group when searching for principals
2dd91f7 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb mentioned this pull request Jun 18, 2025
Merged
2 tasks
kesselb added a commit that referenced this pull request Jun 26, 2025
@kesselb
fix: hide guests group when searching for principals
48938d3 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jul 2, 2025
@kesselb
fix: hide guests group when searching for principals
e6b2661 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
AIlkiv pushed a commit to AIlkiv/server that referenced this pull request Jul 10, 2025
@kesselb @AIlkiv
fix: hide guests group when searching for principals
cd54b46 
Follow-up for nextcloud#52914

Signed-off-by: Daniel Kesselberg <[email protected]>
nilsding added a commit that referenced this pull request Jul 31, 2025
@nilsding
fix: hide guests group from overall principals
45c8664 
Follow-up for #52914 and #53369

Signed-off-by: Jyrki Gadinger <[email protected]>
@nilsding nilsding mentioned this pull request Jul 31, 2025
Merged
4 tasks
backportbot bot pushed a commit that referenced this pull request Jul 31, 2025
@nilsding @backportbot
fix: hide guests group from overall principals
78495da 
Follow-up for #52914 and #53369

Signed-off-by: Jyrki Gadinger <[email protected]>
backportbot bot pushed a commit that referenced this pull request Jul 31, 2025
@nilsding @backportbot
fix: hide guests group from overall principals
9f7d8ed 
Follow-up for #52914 and #53369

Signed-off-by: Jyrki Gadinger <[email protected]>
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@kesselb kesselb

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: GroupPrincipalBackend ignores IHideFromCollaborationBackend

5 participants

@kesselb @st3iny @SebastianKrupinski @skjnldsv