fix(user_ldap): Store the list of used configuration prefixed in appconfig #52916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
fix/cache-ldap-configuration-prefixes
branch
2 times, most recently
from
dd79f10 to
1d0a101
Compare
come-nc
requested review from
ArtificialOwl,
blizzz,
icewind1991,
nfebe and
provokateurin
and removed request for
a team
…onfig This avoids getting all keys from appconfig, which was triggering loading of lazy configuration on all requests. Signed-off-by: Côme Chilliet <[email protected]>
…alls Using OCP\AppFramework\Services\IAppConfig is not possible because the Helper is queried from places outside of the application DI container (ajax pages, tests, other applications through ILDAPProviderFactory…) Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/cache-ldap-configuration-prefixes
branch
from
90269f3 to
b9949b2
Compare
blizzz
approved these changes
Jun 12, 2025
Contributor
Author
|
CI failure unrelated, it’s the flaky |
ArtificialOwl
approved these changes
Jun 19, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This avoids getting all keys from appconfig, which was triggering loading of lazy configuration on all requests.
It should help a bit with performances when user_ldap is enabled.
Checklist