Skip to content

Conversation

@SystemKeeper
Copy link
Contributor

Fixes

1) OCA\Files_Sharing\Tests\EncryptedSizePropagationTest::testSizePropagationWhenOwnerChangesFile
openssl_public_encrypt(): key parameter is not a valid public key

/home/runner/actions-runner/_work/server/server/apps/encryption/lib/Crypto/Crypt.php:655
/home/runner/actions-runner/_work/server/server/apps/encryption/lib/Crypto/Encryption.php:228
/home/runner/actions-runner/_work/server/server/lib/private/Files/Stream/Encryption.php:396
/home/runner/actions-runner/_work/server/server/lib/private/Files/View.php:634
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/File.php:52
/home/runner/actions-runner/_work/server/server/lib/private/legacy/OC_Util.php:196
/home/runner/actions-runner/_work/server/server/lib/private/legacy/OC_Util.php:155
/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php:521
/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php:357
/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php:585
/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php:307
/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/TestCase.php:197
/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/EncryptedSizePropagationTest.php:36
/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/TestCase.php:[111](https://github.com/nextcloud/server/actions/runs/15105747424/job/42454147053#step:7:112)
/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/EncryptedSizePropagationTest.php:21

Minimal repro case:

  • Setup NC with Minio (as is done on CI)
  • Run phpunit --configuration tests/phpunit-autotest.xml --group DB,SLOWDB --filter 'testSizePropagationWhenOwnerChangesFile' --debug

Still not sure why only running the encrypted test works:

phpunit --configuration tests/phpunit-autotest.xml --group DB,SLOWDB --filter 'EncryptedSizePropagationTest::testSizePropagationWhenOwnerChangesFile' --debug

Checklist

@SystemKeeper SystemKeeper marked this pull request as ready for review May 19, 2025 07:25
@SystemKeeper SystemKeeper requested a review from a team as a code owner May 19, 2025 07:25
@SystemKeeper SystemKeeper requested review from artonge, come-nc and provokateurin and removed request for a team May 19, 2025 07:25
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for diving into this

@SystemKeeper SystemKeeper enabled auto-merge May 19, 2025 07:33
@SystemKeeper SystemKeeper merged commit d63803d into master May 19, 2025
219 of 238 checks passed
@SystemKeeper SystemKeeper deleted the fix/noid/encrypted-propagation-test branch May 19, 2025 07:47
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants