fix(SetupManager): Include home and root providers when registering mounts #52972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
approved these changes
May 20, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Looks sane to me.
Any reason IHomeMountProvider and IRootMountProvider are not extending IMountProvider ?
Looks like an oversight to me.
Member
Author
No idea TBH |
…ounts Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/setupmanager/home-root-providers-register-mounts
branch
from
13de209 to
ecfa58d
Compare
susnux
approved these changes
May 20, 2025
provokateurin
deleted the
fix/setupmanager/home-root-providers-register-mounts
branch
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
This was referenced May 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #52957.
On each setup of the FS the home mount for the user was added to the oc_mounts table (while already being present), so a lot of unnecessary overhead.
Checklist