fix(files): do nothing if view local dialog was just closed
#53171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
szaimen
requested review from
Jerome-Herbinet and
nfebe
and removed request for
szaimen
skjnldsv
approved these changes
May 28, 2025
artonge
approved these changes
May 28, 2025
AndyScherzinger
force-pushed
the
fix/view-local-close
branch
from
703b6d1 to
36b93ff
Compare
Member
|
Test failures seem legitimate @susnux |
susnux
force-pushed
the
fix/view-local-close
branch
from
29487ce to
87a855b
Compare
Contributor
Author
wonder how this could ever worked, but fixed it ✅ |
We try to open a file in the Nextcloud client. If this fails a dialog is shown with 3 options: 1. Retry: If it fails no further dialog is shown. 2. Open online: The viewer is used to open the file. 3. Close the dialog and nothing happens (abort). This correctly implements 3 and also adds some comments + order file in reading order (using `function` instead of arrow functions allows this easily). Signed-off-by: Ferdinand Thiessen <[email protected]>
AndyScherzinger
force-pushed
the
fix/view-local-close
branch
from
87a855b to
88a11a5
Compare
Member
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We try to open a file in the Nextcloud client.
If this fails a dialog is shown with 3 options:
This correctly implements 3 and also adds some comments + order file in reading order (using
functioninstead of arrow functions allows this easily).Checklist