Skip to content

refactor(files): migrate away from moment.js #53435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 2 commits into from
Jun 16, 2025
Merged

refactor(files): migrate away from moment.js #53435

susnux merged 2 commits into from
Jun 16, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jun 11, 2025 •
edited
Loading

Summary

Use browser provided API and our shared functions.
This also fixes tests when local language is not English.

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Jun 11, 2025
@susnux susnux added 3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jun 11, 2025
@susnux susnux marked this pull request as ready for review June 11, 2025 12:06
@susnux susnux requested review from a team and skjnldsv as code owners June 11, 2025 12:06
@susnux susnux requested review from artonge and szaimen and removed request for a team June 11, 2025 12:06
@susnux susnux force-pushed the chore/no-moment branch from fa7dea9 to 8dec677 Compare June 11, 2025 12:07
@susnux susnux requested a review from nfebe June 11, 2025 12:07
skjnldsv
skjnldsv approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

szaimen
szaimen approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux
refactor(files): migrate away from moment.js
62e8d01 
Use browser provided API and our shared functions.
This also fixes tests when local language is not English.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the chore/no-moment branch from 8dec677 to 62e8d01 Compare June 16, 2025 10:50
@susnux
Copy link
Contributor Author

susnux commented Jun 16, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
2315dd4 
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command requested a review from a team as a code owner June 16, 2025 10:59
@susnux susnux merged commit c2bf348 into master Jun 16, 2025
134 of 136 checks passed
@susnux susnux deleted the chore/no-moment branch June 16, 2025 12:11
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@nfebe nfebe Awaiting requested review from nfebe

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux @skjnldsv @szaimen @nextcloud-command