chore/rector: make phpunit dataproviders phpunit 12 compatible #53728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ChristophWurst,
SebastianKrupinski,
hamza221,
miaulalala,
nickvergessen,
st3iny and
tcitworld
as code owners
icewind1991
requested review from
Altahrim,
artonge and
sorbaugh
and removed request for
a team
ChristophWurst
approved these changes
Jun 30, 2025
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Reviewed every single line changed /s
icewind1991
force-pushed
the
rector-phpunit10
branch
from
df68155 to
ae3e0fa
Compare
Member
|
Is there any way to import attribute namespaces? |
Member
|
There is a rule for rector to auto import but it will run on all code, not just the changed bits :s |
icewind1991
added
the
♻️ refactor
miaulalala
approved these changes
Jul 1, 2025
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
rector-phpunit10
branch
from
ae3e0fa to
aa15f9d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpunit removed the non-static dataproviders and the docblock based annotation for them