-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
enh(files): Replace "All folders" with "Folder tree structure" #54085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A 2-word naming sounds better to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment but in any case I don't see why this is a separate item in the first place. Couldn't it be merged with All files? By that, I mean just give All files the chevron and only have 1 sidebar item. That sounds like a better solution to me.
Because that was the initial request for the feature :) |
8a11686 to
738b743
Compare
|
@kra-mo do you think that cypress errors are really related to the PR ? |
Don't know, I'm not a developer :D |
738b743 to
4283e05
Compare
|
/compile amend |
Signed-off-by: Jérôme Herbinet <[email protected]> Co-Authored-By: kramo <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
4283e05 to
ee3e628
Compare
|
Out of date bundles :) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
I think that ‘All Folders’ creates confusion with ‘All Files’ located above it, because ‘All Files’ also displays folders. I know there is a small chevron next to ‘All Folders’, but it's not very intuitive. I therefore suggest renaming ‘All folders’ to ‘Folder tree’, which better suggests that it is a matter of displaying a folder tree.
Summary
TODO
Checklist