feat(mounts): optimize load of mounts by filtering on database side #54197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
force-pushed
the
perf/reduce_mount_db_load
branch
2 times, most recently
from
9af0815 to
6d38980
Compare
Member
|
related: #51074 |
Altahrim
force-pushed
the
perf/reduce_mount_db_load
branch
from
6d38980 to
6dca476
Compare
Altahrim
requested review from
ArtificialOwl,
CarlSchwan and
sorbaugh
and removed request for
a team
Altahrim
added
3. to review
salmart-dev
reviewed
Aug 4, 2025
Contributor
salmart-dev
left a comment
salmart-dev
left a comment
There was a problem hiding this comment.
From what I see, the query in getMountsForStorageId has been inlined in this function and extended it with the rules that were previously filtering the rows in PHP.
salmart-dev
approved these changes
Aug 4, 2025
Altahrim
force-pushed
the
perf/reduce_mount_db_load
branch
from
6333c81 to
ef204ec
Compare
Altahrim
force-pushed
the
perf/reduce_mount_db_load
branch
from
ef204ec to
8edae4b
Compare
icewind1991
reviewed
Aug 14, 2025
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
perf/reduce_mount_db_load
branch
from
b98479a to
39e2e70
Compare
icewind1991
approved these changes
Aug 26, 2025
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters mounts on database side to free some database bandwidth