-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(taskprocessing): add cleanup flag to tasks #54272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kesselb
merged 10 commits into
master
from
enh/noid/taskprocessing-task-add-cleanup-flag
Aug 15, 2025
Merged
feat(taskprocessing): add cleanup flag to tasks #54272
kesselb
merged 10 commits into
master
from
enh/noid/taskprocessing-task-add-cleanup-flag
Aug 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a815ed to
8bc4285
Compare
susnux
reviewed
Aug 6, 2025
32754d6 to
2367e50
Compare
marcelklehr
reviewed
Aug 7, 2025
marcelklehr
reviewed
Aug 7, 2025
marcelklehr
reviewed
Aug 7, 2025
9ddea45 to
47ffee2
Compare
marcelklehr
reviewed
Aug 7, 2025
fe39516 to
adabd70
Compare
marcelklehr
approved these changes
Aug 7, 2025
…uld be cleaned up automatically Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
…anager, use it in the cleanup bg job and implement a cleanup command Signed-off-by: Julien Veyssier <[email protected]>
…eted tasks in the cleanup command Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
…classes Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
adabd70 to
aa2ca86
Compare
oleksandr-nc
approved these changes
Aug 11, 2025
Contributor
oleksandr-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Contributor
|
documentation update: nextcloud/documentation#13500 |
|
Feedback from @ChristophWurst : Server template was not followed and documentation requirements are lacking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
feature: text processing
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is useful for the assistant audio chat for example. We don't cleanup the chat message history so we need to prevent cleaning up the AudioChat tasks. Those tasks are deleted when the chat history is deleted.
Changes proposed in this PR:
TaskProcessingApiController::extractFileIdsFromTasktoOCP\TaskProcessing\IManagerto be able to use it elsewhereOC\TaskProcessing\Db\Taskentity classappData/TaskProcessing. It now gets the list of old tasks to cleanup, gets the list of output files for those tasks and delete them. It then deletes the old tasks.taskprocessing:task:cleanupocc commandChecklist