views/UnifiedSearch: trigger on f input rather than qwerty keycode
#54348
Conversation
Before, search would trigger based on the physical keycode of the pressed key; whether that key would _represent_ f on a qwerty keyboard. Anyone not typing qwerty will have search trigger on the same physical button, regardless of whether that button actually types `f` in their respective layout. In my case, I use neo_qwerty which has a layer where the arrow keys are on ESDF. Attempting to jump forward word-wise using `C-<right>` causes global search to open because `<right>` is where f would be on qwerty. Any user with a keyboard layout other than qwerty should be affected by this bug. This makes it so that you have to press the `f` key of your particular layout; wherever that may be. Signed-off-by: Atemu <[email protected]>
Atemu
requested review from
nfebe,
skjnldsv and
susnux
and removed request for
a team
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
ALso .code is not recommended under firefox anymore 👍
|
/backport to stable31 |
|
/backport to stable30 |
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
good for a backport fix, but we should use useHotKey in future as it automatically handles this and also other issues (because f does not exist on all keyboards)
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Basically a port of nextcloud/server#54348 but we don't build the front-end from source, so I have to monkey-patch the minified JS instead.
3 participants
Before, search would trigger based on the physical keycode of the pressed key; whether that key would represent f on a qwerty keyboard.
Anyone not typing qwerty will have search trigger on the same physical button, regardless of whether that button actually types
fin their respective layout.In my case, I use neo_qwerty which has a layer where the arrow keys are on ESDF. Attempting to jump forward word-wise using
C-<right>causes global search to open because<right>is where f would be on qwerty.Any user with a keyboard layout other than qwerty should be affected by this bug.
This makes it so that you have to press the
fkey of your particular layout; wherever that may be.Summary
TODO
Checklist