fix: catch and log exception from share events #54419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
ArtificialOwl,
CarlSchwan and
nfebe
and removed request for
a team
susnux
reviewed
Aug 14, 2025
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
share-event-catch
branch
from
1dad6ce to
dcc6c19
Compare
come-nc
reviewed
Aug 14, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Why have this specifically for share events?
This is the case for any event, any listener can crash the request.
So I’d say either we have that in the dispatcher or we do not have it at all?
Member
Author
|
"Exceptions from events" seem to be used in at least some places |
CarlSchwan
approved these changes
Aug 14, 2025
susnux
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of failing the rest of the request, just log and move on.
Don't let something like nextcloud/activity#2103 stop people from leaving shares without seeing error messages.