Skip to content

fix(theming): Document correct response schema if app is not enabled #54532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Aug 20, 2025
Merged

fix(theming): Document correct response schema if app is not enabled #54532

provokateurin merged 1 commit into from
Aug 20, 2025

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Aug 20, 2025

server/apps/theming/lib/Controller/ThemingController.php

Line 450 in 4733369

$response = new JSONResponse([], Http::STATUS_NOT_FOUND);

@provokateurin provokateurin added this to the Nextcloud 32 milestone Aug 20, 2025
@provokateurin provokateurin requested a review from a team as a code owner August 20, 2025 10:46
@provokateurin provokateurin requested review from CarlSchwan, icewind1991 and leftybournes and removed request for a team August 20, 2025 10:46
@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Aug 20, 2025
@provokateurin provokateurin requested review from a team and susnux August 20, 2025 10:55
@provokateurin provokateurin merged commit 357292f into master Aug 20, 2025
196 checks passed
@provokateurin provokateurin deleted the fix/theming/manifest-not-found-response branch August 20, 2025 13:23
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 22, 2025
Merged
@provokateurin provokateurin mentioned this pull request Aug 25, 2025
Open
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@provokateurin @susnux @CarlSchwan @skjnldsv