Dispatch new event when invalidating an authentication token #54545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
requested review from
AndyScherzinger,
nickvergessen and
oleksandr-nc
julien-nc
requested review from
ArtificialOwl,
CarlSchwan and
leftybournes
and removed request for
a team
julien-nc
added
enhancement
3. to review
julien-nc
force-pushed
the
enh/noid/add-token-invalidated-event
branch
from
fe9a0fd to
df3ac5d
Compare
AndyScherzinger
approved these changes
Aug 20, 2025
oleksandr-nc
approved these changes
Aug 20, 2025
susnux
reviewed
Aug 20, 2025
…vider::invalidateTokenById is called Signed-off-by: Julien Veyssier <[email protected]>
…vider::invalidateToken is called Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/add-token-invalidated-event
branch
from
df3ac5d to
3d36834
Compare
susnux
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatch a new
OCP\Authentication\Events\TokenInvalidatedEventevent inOC\Authentication\Token\PublicKeyTokenProvider::invalidateTokenandOC\Authentication\Token\PublicKeyTokenProvider::invalidateTokenByIdafter having actually invalidated a token.This is one solution to help with nextcloud/user_oidc#1181 in which we need to know when a user session is revoked to terminate the session on the external identity provider side (if needed).
Doc PR: nextcloud/documentation#13522