fix(theming): use IAppConfig instead of IConfig to set theming config #54630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
reviewed
Aug 25, 2025
salmart-dev
requested review from
icewind1991,
sorbaugh and
yemkareems
and removed request for
a team
Signed-off-by: Salvatore Martire <[email protected]>
salmart-dev
force-pushed
the
fix/54626/occThemingTypeError
branch
from
d2cfe74 to
b247c97
Compare
provokateurin
approved these changes
Aug 29, 2025
Contributor
Author
|
/backport to stable31 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conflict between new type (mixed) and old type (string)#54626Summary
The web UI uses IAppConfig to set the theming configuration, which stores the values with their type information. The occ command uses the
ThemingDefaultswhich use the IConfig, which uses mixed instead of the appropriate type, which now fails.Checklist