fix(files_sharing): correctly apply icons and copy share link #54648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
susnux
added
design
AndyScherzinger
approved these changes
Aug 26, 2025
skjnldsv
approved these changes
Aug 26, 2025
AndyScherzinger
force-pushed
the
fix/sharing-entry
branch
from
fa519ed to
b77f36e
Compare
Member
|
/compile |
Member
|
/compile rebase |
1. Use correct color 2. Do not mix legacy icon classes with MDI icons this will show two icons... 3. Use proper aria label and put status into the title Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/sharing-entry
branch
from
359811b to
d27f648
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist