Skip to content

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Aug 26, 2025

Summary

Looks like something we might want to have in the CI

Checklist

@provokateurin
Copy link
Member

Looks like something we might want to have in the CI

Back when we added it we decided against it, because it makes creating PRs even more complicated. It's fine if we just run it once in a while and submit a PR, just like you did.

@CarlSchwan CarlSchwan requested a review from come-nc August 27, 2025 07:41
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Aug 27, 2025
@CarlSchwan CarlSchwan marked this pull request as ready for review August 27, 2025 14:02
@CarlSchwan CarlSchwan requested review from Altahrim and salmart-dev and removed request for a team August 27, 2025 14:02
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CalDAV part looks correct

@provokateurin provokateurin merged commit 45f5daa into master Aug 27, 2025
224 of 230 checks passed
@provokateurin provokateurin deleted the carl/apply-rector branch August 27, 2025 14:30
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants