feat: allow group's members to view fellow members #54691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftybournes
requested review from
CarlSchwan,
come-nc and
yemkareems
and removed request for
a team
Signed-off-by: Kent Delante <[email protected]>
leftybournes
force-pushed
the
leftybournes/feat/teams_groups_readonly
branch
from
4762b76 to
2908f81
Compare
provokateurin
approved these changes
Aug 28, 2025
CarlSchwan
approved these changes
Aug 28, 2025
susnux
approved these changes
Aug 28, 2025
|
come-nc
reviewed
Aug 28, 2025
| $group = $this->groupManager->get($groupId); | ||
| if ($group !== null) { | ||
| $isSubadminOfGroup = $this->groupManager->getSubAdmin()->isSubAdminOfGroup($user, $group); | ||
| $isMember = $this->groupManager->isInGroup($user->getUID(), $group->getGID()); |
Contributor
There was a problem hiding this comment.
Ideally this kind of checks should be done only when $isAdmin is false, to avoid useless queries.
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow a user to view the list of members of their group.
Needed by nextcloud/contacts#4658
Checklist