fix(Accounts): Add back v2 scope migration #54703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
sorbaugh and
yemkareems
and removed request for
a team
Signed-off-by: provokateurin <[email protected]>
susnux
approved these changes
Aug 28, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
We should probably rather do a real migration as this will not be done if only read - meaning if there is no write it will stay there forever...
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/accounts/v2-scope-migration
branch
from
131235b to
53c1268
Compare
Member
Author
|
A real migration would be quite expensive (since it needs to run for every user), but yeah I don't like this either. |
susnux
reviewed
Aug 28, 2025
Contributor
We already did this for others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of #52544.
The database can still contain legacy scopes and when they are loaded,
setScopewill throw an error.The migration needs to stay, as we don't save the migrated scopes back to the database.