Skip to content

fix: add missing listener #54794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 1 commit into from
Sep 2, 2025
Merged

fix: add missing listener #54794

kesselb merged 1 commit into from
Sep 2, 2025

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Sep 2, 2025 •
edited by ChristophWurst
Loading

  • Resolves: none

Summary

Checklist

@st3iny st3iny added this to the Nextcloud 32 milestone Sep 2, 2025
@st3iny st3iny self-assigned this Sep 2, 2025
@st3iny st3iny added the bug label Sep 2, 2025
@st3iny st3iny added the 3. to review Waiting for reviews label Sep 2, 2025
@st3iny st3iny requested review from ArtificialOwl, salmart-dev and yemkareems and removed request for a team September 2, 2025 08:03
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Sep 2, 2025
@st3iny
Copy link
Member Author

st3iny commented Sep 2, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented Sep 2, 2025

/backport to stable30

@st3iny
Copy link
Member Author

st3iny commented Sep 2, 2025

/backport to stable29

@st3iny
Copy link
Member Author

st3iny commented Sep 2, 2025

/backport to stable28

@st3iny
Copy link
Member Author

st3iny commented Sep 2, 2025

/backport to stable27

ChristophWurst
ChristophWurst reviewed Sep 2, 2025
View reviewed changes
@st3iny st3iny force-pushed the fix/add-missing-listener branch from 0ed6fe0 to 04d0e43 Compare September 2, 2025 08:18
@st3iny
Copy link
Member Author

st3iny commented Sep 2, 2025

Psalm failure is unrelated.

Error: lib/private/Repair/RepairMimeTypes.php:482:4: UndefinedVariable: Cannot find referenced variable $out (see https://psalm.dev/024)

salmart-dev
salmart-dev approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@salmart-dev salmart-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 2, 2025
@SebastianKrupinski @st3iny
fix: add missing listener
75419ce 
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny force-pushed the fix/add-missing-listener branch from 04d0e43 to 75419ce Compare September 2, 2025 08:31
@st3iny st3iny enabled auto-merge September 2, 2025 08:31
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 2, 2025
Merged
SebastianKrupinski
SebastianKrupinski approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks familiar :)

Tested. Working.

@kesselb kesselb disabled auto-merge September 2, 2025 12:24
@kesselb kesselb merged commit 480517a into master Sep 2, 2025
235 of 256 checks passed
@kesselb kesselb deleted the fix/add-missing-listener branch September 2, 2025 12:24
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 2, 2025
This was referenced Sep 2, 2025
Merged
Merged
Merged
Merged
Merged
@SebastianKrupinski
Copy link
Contributor

SebastianKrupinski commented Sep 2, 2025

Wow. Smooth backprt

@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@salmart-dev salmart-dev salmart-dev approved these changes

@hamza221 hamza221 hamza221 approved these changes

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

@st3iny st3iny

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feedback-requested

Projects

💌 📅 👥 Groupware team
Status: ☑️ Done

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

8 participants

@st3iny @SebastianKrupinski @ChristophWurst @salmart-dev @hamza221 @kesselb @skjnldsv