feat(SystemTag): Add typed events for tag mapper events #54810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
force-pushed
the
feat/typed-tag-events
branch
from
d408934 to
88913f7
Compare
marcelklehr
requested review from
Altahrim,
nfebe and
provokateurin
and removed request for
a team
provokateurin
requested changes
Sep 2, 2025
susnux
reviewed
Sep 2, 2025
| } | ||
|
|
||
| /** | ||
| * @return array |
Contributor
There was a problem hiding this comment.
Return type annotation is useless if not more specific than the strict types.
So it can either be removed or use proper type:
Suggested change
| * @return array | |
| * @return array{'objectType': string, 'objectId': string, 'tagIds': int[] } |
Member
Author
There was a problem hiding this comment.
mh. psalm doesn't like this
Contributor
There was a problem hiding this comment.
Maybe the quoting is wrong / not needed, see https://psalm.dev/docs/annotating_code/type_syntax/array_types/#array-shapes
Member
Author
There was a problem hiding this comment.
Now it seems to work. Not sure what was the problem.
susnux
reviewed
Sep 2, 2025
marcelklehr
force-pushed
the
feat/typed-tag-events
branch
3 times, most recently
from
b4b89fa to
9fc78f0
Compare
marcelklehr
force-pushed
the
feat/typed-tag-events
branch
from
9fc78f0 to
f2e121f
Compare
provokateurin
requested changes
Sep 3, 2025
marcelklehr
force-pushed
the
feat/typed-tag-events
branch
from
f2e121f to
b924df6
Compare
provokateurin
requested changes
Sep 3, 2025
marcelklehr
force-pushed
the
feat/typed-tag-events
branch
from
b924df6 to
3192567
Compare
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/typed-tag-events
branch
from
3192567 to
2bb2fa5
Compare
provokateurin
approved these changes
Sep 3, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Could also use constructor property promotion, but I don't want to force you to do another round 🙈 Sorry for the back and forth 😞
susnux
approved these changes
Sep 4, 2025
Contributor
|
please do not forget the tags :) |
Contributor
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds typed events for tag mapper events that are also exposed via webhooks.
Checklist